dungdajhjep/d2go
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix magic numbers

Browse Source
This commit is contained in:
guiyomu-dev
2025-11-14 21:34:40 +01:00
parent a5e3194e3c
commit 199ed03b8c
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/nip/rule.go
View File

@@ -462,11 +462,12 @@ func getRequiredStatsForRule(line string) []string {
} }
func evaluateClassSkillsSum(it data.Item) int { func evaluateClassSkillsSum(it data.Item) int {
// Check all class skills stats (all have base ID 83 with different layers) // Check all class skills stats
totalClassSkills := 0 totalClassSkills := 0
maxLayer := 6 // in aliases.go the max layer for class skills is 6 (itemaddassassinskills)
for layer := 0; layer <= 6; layer++ { for layer := 0; layer <= maxLayer; layer++ {
if itemStat, found := it.FindStat(stat.ID(83), layer); found && itemStat.Value > 0 { if itemStat, found := it.FindStat(stat.AddClassSkills, layer); found && itemStat.Value > 0 {
totalClassSkills += itemStat.Value totalClassSkills += itemStat.Value
} }
} }
@@ -474,11 +475,12 @@ func evaluateClassSkillsSum(it data.Item) int {
return totalClassSkills return totalClassSkills
} }
func evaluateSkillTabSum(it data.Item) int { func evaluateSkillTabSum(it data.Item) int {
// Check all skill tab stats (all have base ID 188 with different layers) // Check all skill tab stats
totalSkillTabs := 0 totalSkillTabs := 0
maxLayer := 50 // in aliases.go the max layer for skill tabs is 50 (itemaddmartialartsskilltab)
for layer := 0; layer <= 50; layer++ { for layer := 0; layer <= maxLayer; layer++ {
if itemStat, found := it.FindStat(stat.ID(188), layer); found && itemStat.Value > 0 { if itemStat, found := it.FindStat(stat.AddSkillTab, layer); found && itemStat.Value > 0 {
totalSkillTabs += itemStat.Value totalSkillTabs += itemStat.Value
} }
} }